Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added instructions to disable fedora #2350

Merged
merged 7 commits into from
Sep 25, 2024

Conversation

joshdentremont
Copy link
Contributor

Purpose / why

How to hide fedora from the public in production

What changes were made?

added instructions

Verification

To test this, spin up a production site, and access the fedora repo at fcrepo.${DOMAIN}. Then make the changes described in this PR, and try to access that domain again.

Interested Parties

  • @Islandora/documentation
  • @Islandora/committers

Checklist

Pull-request Reviewer

Pull-request reviewer should ensure the following:

Person Merging

The person merging should ensure the following:

  • Does mkdocs still build successfully? (This is indicated by TravisCI passing. To test locally, and see warnings, see How To Build Documentation.)
  • If pages are renamed or removed, have all internal links to those pages been fixed?
  • If pages are added, have they been linked to or placed in the menu?
  • Did the PR receive at least one approval from a committer, and all issues raised have been addressed?

Copy link
Contributor

@adam-vessey adam-vessey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of typos, and add hints to the code blocks.

joshdentremont and others added 5 commits September 18, 2024 15:02
Co-authored-by: Adam <607975+adam-vessey@users.noreply.github.com>
Co-authored-by: Adam <607975+adam-vessey@users.noreply.github.com>
Co-authored-by: Adam <607975+adam-vessey@users.noreply.github.com>
Co-authored-by: Adam <607975+adam-vessey@users.noreply.github.com>
Co-authored-by: Adam <607975+adam-vessey@users.noreply.github.com>
Co-authored-by: Adam <607975+adam-vessey@users.noreply.github.com>
@adam-vessey adam-vessey merged commit 0636989 into Islandora:main Sep 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants